-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update GridCellParams
value
description
#5849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
docs
Improvements or additions to the documentation
component: data grid
This is the name of the generic UI component, not the React module!
labels
Aug 19, 2022
cherniavskii
commented
Aug 19, 2022
cherniavskii
commented
Aug 19, 2022
@@ -106,6 +106,10 @@ export interface GridValueGetterParams<V = any, R = any> | |||
* @deprecated Use the `apiRef` returned by `useGridApiContext` or `useGridApiRef` (only available in `@mui/x-data-grid-pro`) | |||
*/ | |||
api: any; | |||
/** | |||
* The default value for the cell that the `valueGetter` is overriding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To override GridCellParams['value']
description for valueGetter
, since it doesn't make sense in that case (see #5823 (comment))
These are the results for the performance tests:
|
cherniavskii
force-pushed
the
GridCellParams-value
branch
from
August 19, 2022 16:41
5d9d510
to
4a652db
Compare
m4theushw
approved these changes
Aug 23, 2022
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Sep 20, 2022
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5823